-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix declare of variable #951
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* local train bug fix * normalization update * fix tests * remove test * updated normalization * Naming changes, bug fixes * subtensor update for max clip * max weight to a million * Fixes for ordering and comments * additional tests * string fix * numerical stability and testing updates * minor update for division by zero * Naming and spacing fixes * epsilon update * small fix * additional subtensor parameters * remove print * help string fixes * small bug fix
* add test for expected reregister behaviour * add fix * pass passed args into earlier parse * fix test by using args * exit before actual register * use strtobool Co-authored-by: Unconst <[email protected]>
* add flags for output_in_place during registration * stop tracking best * refactor registration logging output * fix reregister from type bool * change in_place and use_cuda to strtobool * add param and defaults * fix reference before assignment * add new logger to cuda rege * pass param to btcli register call * oops * fix init * try slight timeout * try fix * oop * ? * fix use_cuda flag * add test for new use_cuda flag setup * use create pow to patch * all no prompt dev id * fix console.error * use lower for str comparison * call self register instead * add test for wallet register call * tests are for wallet reregister * fix typo * no self on top-level test * fix tests? * use reregister * typo in test * fix assert * fix assert * should be False * fix time output to use timedelta * add log verbose as option to reg output * should be action * fix typo * add missing function arg * fix spacing * fix flags * fix flags * fix test * should pass in args to config pre-parse * use None instead of NA Co-authored-by: isabella618033 <[email protected]> Co-authored-by: Unconst <[email protected]>
Eugene-hu
approved these changes
Oct 13, 2022
Eugene-hu
added a commit
that referenced
this pull request
Oct 13, 2022
* [feature] external axon flags (#887) * add external axon changes * add defaults for new axon flags * fix args to axon * default to internal ip and port if not specified * add new args and todefaults * add axon unit tests * add description for subtensor integration test * move test to unit test * create new test file add/update copyright notices * don't default to internal ip * add tests for setting the full_address * add tests for subtensor.serve w/external axon info * allow external port config to be None * switch to mock instead of patch * fix test mocks * change mock config create * fix/add default config * change asserts add mesage * fix check call args * fix mock config set * only call once * fix help wording * should be True * [fix] fixes unstake with max-stake flag (#905) * add equality to None to the balance class * add tests for the None case * local train bug fix (#906) * [feature] [CUDA solver] Add multi-GPU and ask for CUDA during btcli run (#893) * added cuda solver * boost versions to fix pip error * allow choosing device id * fix solution check to use keccak * adds params for cuda and dev_id to register * list devices by name during selection * add block number logging * fix calculation of hashrate * fix update interval default * add --TPB arg to register * add update_interval flag * switch back to old looping/work structure * change typing * device count is a function * stop early if wallet registered * add update interval and num proc flag * add better number output * optimize multiproc cpu reg keeping proc until solution * fix test * change import to cubit * fix import and default * up default should have default in CLI call * add comments about params * fix config var access * add cubit as extra * handle stale pow differently check registration after failure * restrict number of processes for integration test * fix stale check * use wallet.is_registered instead * attempt to fix test issue * fix my test * oops typo * typo again ugh * remove print out * fix partly reg test * fix if solution None * fix test? * fix patch * add args for cuda to subtensor * add cuda args to reregister call * add to wallet register the cuda args * fix refs and tests * add for val test also * fix tests with rereg * fix patch for tests * add mock_register to subtensor passed instead * move register under the check for isregistered * use patch obj instead * fit patch object * fix prompt * remove unneeded if * modify POW submit to use rolling submit again * add backoff to block get from network * add test for backoff get block * suppress the dev id flag if not set * remove dest so it uses first arg * fix pow submit loop * move registration status with * fix max attempts check * remove status in subtensor.register * add submit status * change to neuron get instead * fix count * try to patch live display * fix patch * . * separate test cases * add POWNotStale and tests * add more test cases for block get with retry * fix return to None * fix arg order * fix indent * add test to verify solution is submitted * fix mock call * patch hex bytes instead * typo :/ * fix print out for unstake * fix indexing into mock call * call indexing * access dict not with dot * fix other indent * add CUDAException for cubit * up cubit version * [Feature] ask cuda during btcli run (#890) * add ask for cuda reg config in btcli run * suppress unset arg * [Feature] [cuda solver] multi gpu (#891) * change diff display out * remove logging * check cubit support in the check config * allow 1 or more devices in flag * cuda flag should be suppress * modify how cpu count is found * make a solver base class * add a solverbase for CUDA * use mutli process kernel launching, one per GPU * move check under dot get accessor * Feature/cuda solver multi gpu (#892) * change diff display out * remove logging * check cubit support in the check config * allow 1 or more devices in flag * cuda flag should be suppress * modify how cpu count is found * make a solver base class * add a solverbase for CUDA * use mutli process kernel launching, one per GPU * move check under dot get accessor * add All gpus specification * continue trying reg after Stale * catch for OSX * dont use qsize * add test for continue after being stale * patch get_nowait instead of qsize * [Docs] Update old docs link to new link. Change discord invite to custom link (#915) * Update old docs link to new one This change deletes the old gitbooks documentation link and replaces it with the new one. * fix discord links Co-authored-by: Mac Thrasher <[email protected]> * Fix for test_neuron.py (#917) prevents downloading from huggingface * [feature] add --seed option to regen_hotkey (#916) * add seed option to regen hotkey * make seed optional and fix docstring * add tests for both coldkey and hotkey regen w/seed * oops, make seed optional * fix old test, add config.seed * circle ci version update and fix (#920) * Add test_phrases_split unit test Asserts that randomly instantiated compact_topk encodings can be correctly decoded to recover the original topk_tensor. * Update unravel_topk_token_phrases with faster implementation Replaces .tensor_split() with block indexing to avoid extra copy operations. * Rename test_phrases_split to test_random_topk_token_phrases * Unit tests cleanup (#922) * circle ci version update and fix * Test clean up * uncomment test and remove specific test * remove loguru and fix flaky tests * fix syncing * removing tokenizer equivalence + some bug fixes * moving old dataset test * Deactivate test_random_topk_token_phrases unit test * Create topk_tensor on origin device * Normalization Update (#909) * local train bug fix * normalization update * fix tests * remove test * updated normalization * Naming changes, bug fixes * subtensor update for max clip * max weight to a million * Fixes for ordering and comments * additional tests * string fix * numerical stability and testing updates * minor update for division by zero * Naming and spacing fixes * epsilon update * small fix * Adding development workflow documentation and script for bumping the version (#918) BIT-582 Adding development workflow documentation and script for bumping the version * Revert "Normalization Update (#909)" This reverts commit 3990a28. * Parachain registration (#912) * removed ws assumption * removing check * never registered * Fixed sched_getaffinity for mac osx * Started adding parachain support * [hot-fix] fix indent again. add test (#907) fix indent again. add test * Fixed registration check and first time registration * Removed old entrypoint list structure * Fixed unit tests Co-authored-by: Eugene <[email protected]> Co-authored-by: Ala Shaabana <[email protected]> Co-authored-by: Cameron Fairchild <[email protected]> * Bit 583 memory optimization v4 (#929) * set allowed receptor to be 0 in validator to not store any receptor * max_active receptro to 0 * fix * feature/BIT-579/Adding Prometheus (#928) * BIT-582 Adding development workflow documentation and script for bumping the version * BIT-579 Adding prometheus_client==0.14.1 to requirements * BIT-579 Removing wandb defaults from sample_configs * Revert "BIT-579 Removing wandb defaults from sample_configs" This reverts commit 2940cc7. * BIT-579 Starting prometheus code. Adding metric_exporter concept/element and its MetricsExporterFactory * BIT-579 Adding prometheus_client==0.14.1 to requirements * BIT-579 Removing wandb defaults from sample_configs * Revert "BIT-579 Removing wandb defaults from sample_configs" This reverts commit 2940cc7. * BIT-579 Starting prometheus code. Adding metric_exporter concept/element and its MetricsExporterFactory * Revert "BIT-579 Starting prometheus code. Adding metric_exporter concept/element and its MetricsExporterFactory" This reverts commit 8742d7f. * BIT-579 Adding _prometheus to bittensor * BIT-579 Adding prometheus code to bittensor/_neuron/text/core_* * BIT-579 Adding prometheus code to bittensor/_config/config_impl.py. Sends the config to the inprocess prometheus server if it exists. * BIT-579 Adding prometheus code to bittensor/_axon/* * BIT-579 Adding prometheus code to bittensor/_dendrite/* * BIT-579 Fixing syntax error * BIT-579 Fixing missing import: time * BIT-579 fixing typo * BIT-579 fixing test: unit_tests/bittensor_tests/test_neuron.py Co-authored-by: Unconst <[email protected]> * Dendrite Text Generate (#941) * adds generate to dendrite * vune fixes * extend readme Co-authored-by: unconst <[email protected]> * Subtensor and Normalization updates (#936) * local train bug fix * normalization update * fix tests * remove test * updated normalization * Naming changes, bug fixes * subtensor update for max clip * max weight to a million * Fixes for ordering and comments * additional tests * string fix * numerical stability and testing updates * minor update for division by zero * Naming and spacing fixes * epsilon update * small fix * additional subtensor parameters * remove print * help string fixes * version 3.4.0 * Add new PRs to release (#944) * Prometheus bug fix (#942) * local train bug fix * normalization update * fix tests * remove test * updated normalization * Naming changes, bug fixes * subtensor update for max clip * max weight to a million * Fixes for ordering and comments * additional tests * string fix * numerical stability and testing updates * minor update for division by zero * Naming and spacing fixes * epsilon update * small fix * additional subtensor parameters * remove print * help string fixes * small bug fix * [Fix] only reregister if flag is set (#937) * add test for expected reregister behaviour * add fix * pass passed args into earlier parse * fix test by using args * exit before actual register * use strtobool Co-authored-by: Unconst <[email protected]> * [BIT 584] [feature] btcli register output stats not in place (#923) * add flags for output_in_place during registration * stop tracking best * refactor registration logging output * fix reregister from type bool * change in_place and use_cuda to strtobool * add param and defaults * fix reference before assignment * add new logger to cuda rege * pass param to btcli register call * oops * fix init * try slight timeout * try fix * oop * ? * fix use_cuda flag * add test for new use_cuda flag setup * use create pow to patch * all no prompt dev id * fix console.error * use lower for str comparison * call self register instead * add test for wallet register call * tests are for wallet reregister * fix typo * no self on top-level test * fix tests? * use reregister * typo in test * fix assert * fix assert * should be False * fix time output to use timedelta * add log verbose as option to reg output * should be action * fix typo * add missing function arg * fix spacing * fix flags * fix flags * fix test * should pass in args to config pre-parse * use None instead of NA Co-authored-by: isabella618033 <[email protected]> Co-authored-by: Unconst <[email protected]> * [Fix] multi cuda fix (#940) * adjust none end calculation * attempt to fix stop issue * modify stop * update nonce_start by correct amount * fix nonce init to only random and update * fix update amount * add start values * add test * try different hashrate calc * try EWMA for hash_rate * oops bad import * change name to worker * extract helper and modify comment * fix time now * catch Full * use a finished queue instead of times * move constants to function params * fix name of n * fix verbose log * allow --output_in_place * fix n * change to --no_ouput_in_place * fix test Co-authored-by: Eugene-hu <[email protected]> Co-authored-by: Unconst <[email protected]> Co-authored-by: isabella618033 <[email protected]> * [Fix] Fix declare of variable (#951) * adjust none end calculation * attempt to fix stop issue * modify stop * update nonce_start by correct amount * fix nonce init to only random and update * fix update amount * add start values * add test * try different hashrate calc * try EWMA for hash_rate * oops bad import * change name to worker * extract helper and modify comment * fix time now * catch Full * Prometheus bug fix (#942) * local train bug fix * normalization update * fix tests * remove test * updated normalization * Naming changes, bug fixes * subtensor update for max clip * max weight to a million * Fixes for ordering and comments * additional tests * string fix * numerical stability and testing updates * minor update for division by zero * Naming and spacing fixes * epsilon update * small fix * additional subtensor parameters * remove print * help string fixes * small bug fix * use a finished queue instead of times * move constants to function params * [Fix] only reregister if flag is set (#937) * add test for expected reregister behaviour * add fix * pass passed args into earlier parse * fix test by using args * exit before actual register * use strtobool Co-authored-by: Unconst <[email protected]> * fix name of n * [BIT 584] [feature] btcli register output stats not in place (#923) * add flags for output_in_place during registration * stop tracking best * refactor registration logging output * fix reregister from type bool * change in_place and use_cuda to strtobool * add param and defaults * fix reference before assignment * add new logger to cuda rege * pass param to btcli register call * oops * fix init * try slight timeout * try fix * oop * ? * fix use_cuda flag * add test for new use_cuda flag setup * use create pow to patch * all no prompt dev id * fix console.error * use lower for str comparison * call self register instead * add test for wallet register call * tests are for wallet reregister * fix typo * no self on top-level test * fix tests? * use reregister * typo in test * fix assert * fix assert * should be False * fix time output to use timedelta * add log verbose as option to reg output * should be action * fix typo * add missing function arg * fix spacing * fix flags * fix flags * fix test * should pass in args to config pre-parse * use None instead of NA Co-authored-by: isabella618033 <[email protected]> Co-authored-by: Unconst <[email protected]> * fix verbose log * allow --output_in_place * fix n * change to --no_ouput_in_place * fix test * fix ref to solution Co-authored-by: Eugene-hu <[email protected]> Co-authored-by: Unconst <[email protected]> Co-authored-by: isabella618033 <[email protected]> * [Fix] pin wandb lower (#952) pin lower Co-authored-by: Cameron Fairchild <[email protected]> Co-authored-by: Mac Thrasher <[email protected]> Co-authored-by: opentaco <[email protected]> Co-authored-by: opentaco <[email protected]> Co-authored-by: Eduardo García <[email protected]> Co-authored-by: Ala Shaabana <[email protected]> Co-authored-by: Ala Shaabana <[email protected]> Co-authored-by: isabella618033 <[email protected]> Co-authored-by: Unconst <[email protected]> Co-authored-by: unconst <[email protected]> Co-authored-by: Cameron Fairchild <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.